Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pacify PPJ teething problems #36

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Pacify PPJ teething problems #36

wants to merge 12 commits into from

Conversation

XxX-Daniil-underscore-Zaikin-XxX
Copy link
Contributor

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX commented Jun 18, 2024 •
edited
Loading

I've encountered a couple of issues when trying to use PPJ files. This is an attempt to fix them.

So far, this PR:

  • Fixes import directories being treated as files
  • Fixes crash when source files have lines shorter than 9 chars before scriptname declaration
  • Changes the default value of the skyrim-allow-unknown-event... option to align with the other Strict checks (i.e. disabled by default).
  • Allows some keywords to be used as function parameters, with the proper strict check. Can be extended to do more.

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX marked this pull request as draft June 19, 2024 06:22
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XxX-Daniil-underscore-Zaikin-XxX