Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You have to click the editor to get key shortcuts to work again in IE9 #134

Closed
OscarGodson opened this issue Jun 27, 2012 · 0 comments
Closed

You have to click the editor to get key shortcuts to work again in IE9 #134

OscarGodson opened this issue Jun 27, 2012 · 0 comments
Labels
0.2.1 Bug IE9 QA'd
Milestone
1.0

Comments

@OscarGodson
Copy link
Owner

To reproduce:

  1. Click on the editor
  2. Press alt+p to preview
  3. Press alt+o to edit
  4. Notice that the edit shortcut didn't work like Chrome and Firefox
  5. Click on the editor
  6. repeat step 3
  7. Note that edit mode finally fires.

As with Firefox, this probably has to do with the fact no focus is on that iframe when you switch. In the edit() and preview() code I have self.editorIframe.focus() and self.previewerIframe.focus() respectively which fixed Firefox, but apparently not IE9.
@OscarGodson OscarGodson mentioned this issue Apr 20, 2013
Closed
OscarGodson added a commit that referenced this issue Apr 20, 2013
@OscarGodson
Ticket #134 #223 - Added focus() method which does the dirty work of …
531a978 
…getting

focus to work across browsers. This also fixes the problem with IE9/10 where
the shortcuts only worked the first time and you had to click into the editor
to get them to work again.

To do: docs and tests
OscarGodson added a commit that referenced this issue Apr 21, 2013
@OscarGodson
Ticket #134 #223 - Added docs for focus() method.
41e61f0
OscarGodson added a commit that referenced this issue May 17, 2013
@OscarGodson
Ticket #134 #223 - Removed focus and blur events from the docs. Addin…
21766af 
…g that as

another ticket for 0.3.0
OscarGodson added a commit that referenced this issue May 17, 2013
@OscarGodson
Ticket #134 #223 - Now the focus() method is working across browsers.…
82051ae 
… Removed

is() support since it was turning out to be too much work. It's now it's own
ticket (#229).

This fixes the IE9/10 issue where the editor was not focused so you could
keep typing after switching over to the preview() (through clicking the icons
or doing a key command).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.2.1 Bug IE9 QA'd
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@OscarGodson