Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #204 - sync textarea with exported text rather than raw text #206

Closed
wants to merge 2 commits into from

Conversation

lamplightdev
Copy link
Contributor

As per ticket #204 a synced textarea was giving   in place of regular spaces on Firefox. This was because the textarea was being synced from getFiles which gives the raw content from localStorage. This doesn't allow for the vagaries of space handling in contenteditables accross browsers. exportFile does aleady allow for these inconsistencies however so I have changed the code so that textareas are now synced using exportFile rather than getFiles.

@OscarGodson
Copy link
Owner

This patch does in fact work. getFiles should work the same. I've been banging my head trying to come up with a solution to get getFiles to work correctly (_setText and _getText need some refactoring), but I guess we can do exportFile so that at least develop works for now.

Couple requests for the pull request :)

  1. Could you send a patch that doesn't have so many whitespace changes?
  2. Can you build your change? (jake build)
  3. Shouldn't break any, but make sure you run the tests also (jake test)

Thanks!

@lamplightdev
Copy link
Contributor Author

That should be sorted now, although I made another pull request with the changes in.

@lamplightdev lamplightdev deleted the firefox-nbsp branch February 7, 2013 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants