[Rule] EnsureExplicitNullableTypes #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may need a bit of help to finalize this (not sure if i can do anything regarding CI checks) |
alamirault
requested changes
Apr 14, 2024
There was a problem hiding this comment.
Thank you @smnandre for this new rule !
I've made some suggestions
|
Right now it runs on every RST file line. We should check in the rule if we are in a Php code block. |
Thanks, just needed to understand the lines / number / block logic :) |
OskarStark
approved these changes
Apr 14, 2024
OskarStark
added a commit
that referenced
this pull request
Apr 14, 2024
* develop: New rule `EnsureExplicitNullableTypes` (#1711) github-actions(deps): bump stefanzweifel/git-auto-commit-action (#1709) github-actions(deps): bump docker/setup-buildx-action (#1708) composer(deps-dev): bump phpunit/phpunit from 10.5.16 to 10.5.17 (#1707) composer(deps-dev): bump rector/rector from 1.0.3 to 1.0.4 (#1706)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CF #1710