Fix for #28 - ESLEvent.body is now also a dictionary key. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think there is a chance that this key could conflict with some event header? |
|
Lol, i don't know why tests are running fine on my end, but i see it has to fail 😆 I'll fix that ... |
It's an additional header/dict key, i don't think so. But i'll check some things... |
|
You are right, let's not complicate things. Maybe there is some conflicting header in the future and we can't change back with that. So |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to get the body data in #28 with
response.body, but it's a UserDict, so i think it should also be a key.