Change over time chart #1973
Merged
Change over time chart #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pflopez
reviewed
Jan 6, 2025
src/interface/src/app/treatments/change-over-time-chart/change-over-time-chart.component.html
Outdated
Show resolved
Hide resolved
src/interface/src/app/treatments/change-over-time-chart/change-over-time-chart.component.ts
Outdated
Show resolved
Hide resolved
src/interface/src/app/treatments/direct-impacts.state.service.ts
Outdated
Show resolved
Hide resolved
src/interface/src/app/treatments/change-over-time-chart/change-over-time-chart.component.ts
Show resolved
Hide resolved
pflopez
reviewed
Jan 7, 2025
src/interface/src/app/treatments/change-over-time-chart/change-over-time-chart.component.ts
Outdated
Show resolved
Hide resolved
pflopez
reviewed
Jan 7, 2025
|
|
||
| @Injectable() |
There was a problem hiding this comment.
We don't want to do this. this is provided by the module, so its not bundled on the main chunk
pflopez
reviewed
Jan 7, 2025
| @@ -44,6 +44,7 @@ | |||
| "chartjs-plugin-datalabels": "^2.2.0", | |||
| "esri-leaflet": "^3.0.12", | |||
| "esri-leaflet-vector": "^4.2.4", | |||
| "fast-deep-equal": "^3.1.3", | |||
There was a problem hiding this comment.
question, are we using this dependency?
There was a problem hiding this comment.
yeah, that's for the deepEqual in the distinctUntilChanged piece. We also don't have anything similar anywhere else, so I thought we could use this, and later maybe replace some JSON.stringify() comparisons we've got.
pflopez
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there are a few things we should adjust when the new dialog component is in place, but otherwise, this seems to be working fine.