Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pylint and apply new lint fixes #516

Merged
merged 7 commits into from
May 6, 2022
Merged

Conversation

fmigneault
Copy link
Collaborator

No description provided.

@fmigneault fmigneault requested a review from ChaamC May 4, 2022 19:17
@github-actions github-actions bot added api Something related to the API operations ci Something related to code tests, deployment and packaging cli Something related to the CLI helpers db Issues related to database connection, migration or data models plugin Service plugin security New security features or failing AuthN/AuthZ conditions tests Test execution or additional use cases ui Something related to the UI operations or display webhook Item related to webhooks functionality. labels May 4, 2022
@fmigneault fmigneault removed the request for review from ChaamC May 4, 2022 19:19
@fmigneault fmigneault self-assigned this May 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #516 (561b5fb) into master (27e060a) will decrease coverage by 0.01%.
The diff coverage is 69.49%.

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   80.27%   80.26%   -0.02%     
==========================================
  Files          71       71              
  Lines        9615     9615              
  Branches     1323     1323              
==========================================
- Hits         7718     7717       -1     
- Misses       1597     1598       +1     
  Partials      300      300              
Impacted Files Coverage Δ
magpie/api/login/__init__.py 100.00% <ø> (ø)
magpie/register.py 48.26% <18.18%> (+<0.01%) ⬆️
magpie/models.py 89.13% <60.00%> (ø)
magpie/api/login/login.py 57.67% <66.66%> (ø)
magpie/ui/utils.py 67.39% <66.66%> (ø)
magpie/services.py 79.52% <71.42%> (ø)
magpie/adapter/magpieservice.py 58.10% <83.33%> (ø)
magpie/api/exception.py 93.52% <100.00%> (ø)
magpie/api/management/user/user_utils.py 97.11% <100.00%> (ø)
magpie/api/schemas.py 99.69% <100.00%> (-0.01%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91ef1d...561b5fb. Read the comment docs.

@fmigneault fmigneault merged commit d2857cb into master May 6, 2022
@fmigneault fmigneault deleted the fix-lint-updates branch May 6, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the API operations ci Something related to code tests, deployment and packaging cli Something related to the CLI helpers db Issues related to database connection, migration or data models plugin Service plugin security New security features or failing AuthN/AuthZ conditions tests Test execution or additional use cases ui Something related to the UI operations or display webhook Item related to webhooks functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants