Skip to content

Commit

Permalink
Merge pull request #82 from Ouranosinc/fix-incorrect-calculation-of-n…
Browse files Browse the repository at this point in the history
…umber-of-failed-tests-in-stress-test-ipynb

Fix incorrect calculation of number of failed tests in stress-test.ipynb

# Overview

Fix `stress-test.ipynb` incorrectly throw error when there are no errors!

## Changes

- stress-test.ipynb: fix incorrect calculation of number of failed tests (when no tests had any errors it was reporting all 4 had error, regression introduced by PR #81)
- stress-test.ipynb: fix incorrect variable access (class method was using global var `results` instead of `self`, copy/paste error during code refactoring in PR #74)
  • Loading branch information
tlvu authored Jul 16, 2021
2 parents 8befaf5 + da918ec commit ccac0b4
Show file tree
Hide file tree
Showing 2 changed files with 426 additions and 425 deletions.
2 changes: 2 additions & 0 deletions conftest.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
def pytest_collectstart(collector):
# Make sure ancestor folder name do not end with `.ipynb`, else we have
# AttributeError: 'Session' object has no attribute 'skip_compare'.
if collector.fspath and collector.fspath.ext == '.ipynb':
collector.skip_compare += 'text/html', 'application/javascript',
Loading

0 comments on commit ccac0b4

Please sign in to comment.