Update nbval sanitize config for pavics sdi regridding notebook #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For error like: ``` 10:26:02 _ pavics-sdi-fix-regridding-nb-to-pass-jenkins/docs/source/notebooks/regridding.ipynb::Cell 9 _ 10:26:02 Notebook cell execution failed 10:26:02 Cell 9: Cell outputs differ 10:26:02 10:26:02 Input: 10:26:02 %%time 10:26:02 reg_cons = xe.Regridder(ds_in_crns, ds_tgt, 'conservative', filename='conservative_regridder.nc') 10:26:02 print(reg_cons) 10:26:02 10:26:02 # Regrid as before 10:26:02 sic_cons = reg_cons(ds_in_crns.siconc) 10:26:02 10:26:02 Traceback: 10:26:02 mismatch 'stdout' 10:26:02 10:26:02 assert reference_output == test_output failed: 10:26:02 10:26:02 'xESMF Regrid...ime: 4.84 s\n' == 'xESMF Regrid...ime: 5.19 s\n' 10:26:02 Skipping 269 identical leading characters in diff, use -v to show 10:26:02 - mes: user 5.04 s, sys: 148 ms, total: 5.19 s 10:26:02 ? ^ ^ ^^ ^ ^^ 10:26:02 + mes: user 4.74 s, sys: 110 ms, total: 4.84 s 10:26:02 ? ^ ^ ^^ ^ ^^ 10:26:02 - Wall time: 5.19 s 10:26:02 ? ^ ^^ 10:26:02 + Wall time: 4.84 s 10:26:02 ? ^ ^^ ```
Note Wall time was replaced correctly. ``` 10:46:14 assert reference_output == test_output failed: 10:46:14 10:46:14 'xESMF Regrid...time: NUM s\n' == 'xESMF Regrid...time: NUM s\n' 10:46:14 Skipping 272 identical leading characters in diff, use -v to show 10:46:14 - : user 4.75 s, sys: 167 ms, total: 4.92 s 10:46:14 ? ^ ^^ ^^ 10:46:14 + : user 4.74 s, sys: 110 ms, total: 4.84 s 10:46:14 ? ^ ^^ ^^ 10:46:14 Wall time: NUM s ```
… works this time Note Wall time worked: ``` 10:59:16 assert reference_output == test_output failed: 10:59:16 10:59:16 'xESMF Regrid...time: NUM s\n' == 'xESMF Regrid...time: NUM s\n' 10:59:16 Skipping 269 identical leading characters in diff, use -v to show 10:59:16 - mes: user 5.67 s, sys: 172 ms, total: 5.85 s 10:59:16 ? ^ - ^^ ^ ^ 10:59:16 + mes: user 4.74 s, sys: 110 ms, total: 4.84 s 10:59:16 ? ^ + ^^ ^ ^ 10:59:16 Wall time: NUM s ```
…it wasn't working
Note replacement worked but did not match until the end: ``` 11:15:40 assert reference_output == test_output failed: 11:15:40 11:15:40 'xESMF Regrid...time: NUM s\n' == 'xESMF Regrid...time: NUM s\n' 11:15:40 Skipping 296 identical leading characters in diff, use -v to show 11:15:40 - al: NUM s.19 s 11:15:40 ? ^^ 11:15:40 + al: NUM s.84 s 11:15:40 ? ^^ 11:15:40 Wall time: NUM s ```
…ng (forgot 'user')
This was referenced Mar 16, 2021
tlvu
deleted the
update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook
branch
tlvu
added a commit
to Ouranosinc/pavics-sdi
that referenced
this pull request
Mar 16, 2021
…kins Fix regridding nb to pass jenkins Requires Ouranosinc/PAVICS-e2e-workflow-tests#63 and bird-house/birdhouse-deploy#132 to have passing Jenkins. Passing Jenkins: http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/10/console See commits for list of what has been done.
tlvu
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Mar 16, 2021
finch: update to 0.7.0 Require PR #131 for extra testdata for the new regridding notebook. Regridding notebook will also need to be adjusted for some output to pass Jenkins test suite, PR Ouranosinc/pavics-sdi#206. Nbval escape regex also needed for the regridding notebook, PR Ouranosinc/PAVICS-e2e-workflow-tests#63 See Finch changelog in PR bird-house/finch#158 Passing Jenkins build http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/10/console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this regridding notebook https://github.com/Ouranosinc/pavics-sdi/blob/bbe3061dceb98688e9fd58836fbc50992ee31568/docs/source/notebooks/regridding.ipynb (PR Ouranosinc/pavics-sdi#201) to pass Jenkins.
Double Jenkins run to be sure:
http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/7/console
http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/8/console
Jenkins passing also required bird-house/birdhouse-deploy#132 and Ouranosinc/pavics-sdi#206