Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor update to GitHub Actions #1221

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Minor update to GitHub Actions #1221

merged 8 commits into from
Nov 8, 2022

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 2, 2022 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes a few Actions to have them trigger properly (triggering on label)
  • Updates Ubuntu images for all actions
  • Minor typo fix in history

Does this PR introduce a breaking change?

Nope.

Other information:

@Zeitsperre Zeitsperre self-assigned this Nov 2, 2022
@github-actions github-actions bot added CI Automation and Contiunous Integration docs Improvements to documenation labels Nov 2, 2022
@Zeitsperre Zeitsperre added approved Approved for additional tests and removed approved Approved for additional tests labels Nov 2, 2022
@Zeitsperre Zeitsperre requested a review from a team November 2, 2022 21:06
@Zeitsperre Zeitsperre added this to the v0.40 milestone Nov 7, 2022
@tlogan2000 tlogan2000 requested a review from aulemahal November 8, 2022 18:55
aulemahal
aulemahal approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/workflows/bump-version.yml

jobs:
bump_patch_version:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the latest keyword disappear?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest is ubuntu-20.04. I'll change it back to latest when ubuntu-22.04 becomes the new latest. Why use 22.04? It comes with newer Python versions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, seems confusing to me that latest isn't, you know, the "latest". But what can we do...

@github-actions github-actions bot added the approved Approved for additional tests label Nov 8, 2022
@Zeitsperre Zeitsperre merged commit c29f1f1 into master Nov 8, 2022
@Zeitsperre Zeitsperre deleted the update-actions branch November 8, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @aulemahal