Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New variables section in yaml module #1231

Merged
merged 4 commits into from
Nov 15, 2022
Merged

New variables section in yaml module #1231

merged 4 commits into from
Nov 15, 2022

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Virtual modules can add variables to xclim.core.utils.VARIABLES through the new variables section of the yaml files.

Does this PR introduce a breaking change?

No.

@aulemahal aulemahal requested a review from RondeauG November 9, 2022 23:15
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added docs Improvements to documenation indicators Climate indices and indicators labels Nov 9, 2022
RondeauG
RondeauG reviewed Nov 10, 2022
View reviewed changes
xclim/core/indicator.py Outdated Show resolved Hide resolved
xclim/core/indicator.py Outdated Show resolved Hide resolved
xclim/core/indicator.py Show resolved Hide resolved
RondeauG
RondeauG approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added the approved Approved for additional tests label Nov 11, 2022
@Zeitsperre Zeitsperre added approved Approved for additional tests and removed approved Approved for additional tests labels Nov 11, 2022
@aulemahal aulemahal merged commit 97ea8ea into master Nov 15, 2022
@aulemahal aulemahal deleted the yaml-variables branch November 15, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules should tolerate non-xclim variable names
3 participants
@aulemahal @RondeauG @Zeitsperre