Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More diags #1252

Merged
merged 55 commits into from
Feb 27, 2023
Merged

More diags #1252

merged 55 commits into from
Feb 27, 2023

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Dec 5, 2022 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Add 2 properties:decorrelation_length and transition_probability

Does this PR introduce a breaking change?

no

Other information:

decorrelation_length was used on the small performance zones for the analysis of ESPO-G, but it does not work on info-crue data (ERA5-Land resolution over Québec).

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Dec 5, 2022
Zeitsperre
Zeitsperre reviewed Dec 5, 2022
View reviewed changes
xclim/sdba/properties.py Outdated Show resolved Hide resolved
juliettelavoie and others added 4 commits December 5, 2022 11:23
@juliettelavoie @Zeitsperre
Update xclim/sdba/properties.py
dbbd0ca 
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@juliettelavoie
Merge remote-tracking branch 'origin/more-diags' into more-diags
38c74fc
@juliettelavoie
format
b9859c9
@juliettelavoie
doc
83eed15
aulemahal
aulemahal reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review for now: decorrelation_length is not made for a 17h50 task. 😅

xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
juliettelavoie and others added 2 commits December 6, 2022 09:10
@juliettelavoie @aulemahal
Update xclim/sdba/properties.py
989be61 
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@juliettelavoie @aulemahal
Update xclim/sdba/properties.py
6bcc059 
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Dec 12, 2022
aulemahal
aulemahal reviewed Dec 12, 2022
View reviewed changes
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CI Automation and Contiunous Integration label Dec 13, 2022
aulemahal
aulemahal reviewed Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another run of comments.
I am going to play with it today, but it looks good! Thanks!

xclim/sdba/nbutils.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
aulemahal
aulemahal reviewed Dec 13, 2022
View reviewed changes
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
xclim/sdba/properties.py Outdated Show resolved Hide resolved
juliettelavoie and others added 13 commits December 13, 2022 13:45
@juliettelavoie
fill diag
02922c1
@juliettelavoie
Merge remote-tracking branch 'origin/more-diags' into more-diags
f8aa6ba
@juliettelavoie @aulemahal
Update xclim/sdba/properties.py
4c21a57 
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@juliettelavoie @aulemahal
Update xclim/sdba/properties.py
60cf695 
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
06f9c27 
for more information, see https://pre-commit.ci
@juliettelavoie @aulemahal
Update xclim/sdba/properties.py
e70f3ca 
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@juliettelavoie @aulemahal
Apply suggestions from code review
5fe3cb5 
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@aulemahal
Improve spatial_correlogram with binned_statistic
452e6cb
@juliettelavoie
mask nan
975af61
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
679feab 
for more information, see https://pre-commit.ci
@Zeitsperre
Merge branch 'master' into more-diags
39c058d
@Zeitsperre
Merge branch 'master' into more-diags
54f1d3f
@Zeitsperre
Merge branch 'master' into more-diags
1f4666f
aulemahal
aulemahal approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@github-actions github-actions bot added the approved Approved for additional tests label Feb 27, 2023
@Zeitsperre Zeitsperre merged commit ff52bed into master Feb 27, 2023
@Zeitsperre Zeitsperre deleted the more-diags branch February 27, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre left review comments

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliettelavoie @Zeitsperre @aulemahal