-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from setup.py to pyproject.toml (PEP 517 and PEP 621) #1278
Conversation
for more information, see https://pre-commit.ci
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…onfiguration error
This PR is ready for final review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I have an unrelated suggestion and an alternative fix.
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@aulemahal test-py39-opt-slow is consistently giving me the following:
Is this just a matter of adjusting tolerances, or should I be investigating further? |
argh. |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
setup.py
is no longer used as the packaging system,pyproject.toml
with flit is now the packaging engine.pyproject.toml
What other changes need to happen?
README and HISTORY require a pre-build step in order to properly be packaged and uploaded to PyPI. The ways this was done to date involved a hacky string replace step insetup.py
. This might now need to be handled with a build-helper scriptDoes this PR introduce a breaking change?
Yes. Very much. Installation of the package should be the same on the user end, but development tooling has changed significantly. Documentation will need to be updated accordingly.
Other information:
https://chadsmith.dev/python-packaging/