Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove change_significance #1737

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Remove change_significance #1737

merged 4 commits into from
Apr 29, 2024

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • change_significance was marked as deprecated in 0.47, to be removed in 0.49, which is the next version.

Does this PR introduce a breaking change?

Technically, no.

Other information:

@aulemahal aulemahal requested a review from Zeitsperre April 29, 2024 17:35
@github-actions github-actions bot added the docs Improvements to documenation label Apr 29, 2024
Zeitsperre
Zeitsperre approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to mention the breaking changes.

@github-actions github-actions bot added the approved Approved for additional tests label Apr 29, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.941% (+0.2%) from 90.769%
when pulling 571251c on rm-change-significance
into 9a87705 on main.

Zeitsperre
Zeitsperre reviewed Apr 29, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
@aulemahal @Zeitsperre
Update CHANGES.rst
fd05912 
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@aulemahal aulemahal merged commit de7ce84 into main Apr 29, 2024
19 checks passed
@aulemahal aulemahal deleted the rm-change-significance branch April 29, 2024 19:45
@Zeitsperre Zeitsperre mentioned this pull request May 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aulemahal @coveralls @Zeitsperre