Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adapt_freq example in notebook #1742

Merged
merged 3 commits into from
May 2, 2024
Merged

Fix adapt_freq example in notebook #1742

merged 3 commits into from
May 2, 2024

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

In the frequency adaptation example, pr_sim was sent to adapt_freq and then to the train. However, this should be hist instead.

Does this PR introduce a breaking change?

No.

Other information:

Also changed the year in the citation.

@aulemahal aulemahal requested review from Zeitsperre and coxipi May 2, 2024 20:56
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label May 2, 2024
coxipi
coxipi approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@github-actions github-actions bot added the approved Approved for additional tests label May 2, 2024
@aulemahal aulemahal merged commit 215fa70 into main May 2, 2024
26 checks passed
@aulemahal aulemahal deleted the fix-adapt-freq-example branch May 2, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

@Zeitsperre Zeitsperre Awaiting requested review from Zeitsperre

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarifying instructions in "First example : pr and frequency adaptation" example
2 participants
@aulemahal @coxipi