Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pint below v0.24 #1773

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Pin pint below v0.24 #1773

merged 3 commits into from
Jun 10, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jun 7, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Pinned pint below v0.24 until we have time to adapt to their new API.
  • Updated the dependency-review action

Does this PR introduce a breaking change?

Yes, pint is now pinned and astroid has been removed from the environment.yml (was unused).

Other information:

https://pint.readthedocs.io/en/stable/changes.html

@Zeitsperre Zeitsperre self-assigned this Jun 7, 2024
@Zeitsperre Zeitsperre requested review from huard and aulemahal June 7, 2024 20:57
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Jun 7, 2024
@Zeitsperre Zeitsperre requested a review from tlogan2000 June 7, 2024 21:13
@Zeitsperre
Copy link
Collaborator Author

@Ouranosinc/xclim-core

The issues with pint will affect all new installations. We should be releasing a patch version as soon as we reasonably can.

@github-actions github-actions bot added the approved Approved for additional tests label Jun 10, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.598%. first build
when pulling 1613f8f on pin-pint
into 1f40f13 on main.

@Zeitsperre Zeitsperre merged commit c213e89 into main Jun 10, 2024
29 checks passed
@Zeitsperre Zeitsperre deleted the pin-pint branch June 10, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants