Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOSS Article, Review badge and Citation information #250

Merged
merged 57 commits into from
May 19, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jul 3, 2019

Pull Request Checklist:

What kind of change does this PR introduce?

This PR finalizes the submission and publishing steps for the Journal of Open Source Software. The paper is expected to have a length of 250 - 1000 words and demands that the software is feature-complete. As such, the submission process should not be started until we have at the very least added all necessary indicators from our backlog and/or stabilized our API (i.e.: v1.0-alpha or release-candidate).

Updates (May 2023):
With xclim v0.40.0, the software was deemed ready for submission. The review process for JOSS was completed via PyOpenSci (pyOpenSci/software-submission#73), and the final JOSS review was performed in openjournals/joss-reviews#5415. The software (v0.43.0) and paper were published on 18 May 2023 (https://doi.org/10.21105/joss.05415).

Does this PR introduce a breaking change?

No.

@Zeitsperre Zeitsperre added enhancement New feature or request help wanted Extra attention is needed standards / conventions Suggestions on ways forward labels Jul 3, 2019
@Zeitsperre Zeitsperre added this to the v1.0 milestone Jul 3, 2019
@Zeitsperre Zeitsperre removed the enhancement New feature or request label Jul 3, 2019
@coveralls
Copy link

coveralls commented Jul 3, 2019

Coverage Status

Coverage: 90.614%. Remained the same when pulling 2794319 on joss_submission into 60f469a on master.

@bzah
Copy link
Contributor

bzah commented Oct 22, 2021

I'm not sure how necessary it is but you may want to add to the biblio:

  • "[HyndmanFan] Hyndman, R. J., & Fan, Y. (1996). Sample quantiles in statistical packages. The American Statistician, 50(4), 361-365." PDF.
    For percentile calculation with alpha and beta.
  • "Zhang, X., Hegerl, G., Zwiers, F. W., & Kenyon, J. (2005). Avoiding Inhomogeneity in Percentile-Based Indices of
    Temperature Extremes, Journal of Climate, 18(11), 1641-1651, https://doi.org/10.1175/JCLI3366.1"
    For percentile bootstrapping.

@Zeitsperre
Copy link
Collaborator Author

@bzah Thanks for those. We haven't advanced on this yet, as we want to reach something feature-complete first, with a stable API. I think (hope) we'll be working on this PR in the new year. We'll see.

@tlogan2000 tlogan2000 modified the milestones: v1.0, v0.41 Nov 8, 2022
@huard huard marked this pull request as ready for review November 29, 2022 13:21
@malngu
Copy link

malngu commented May 17, 2023

ATTN: @jwenfai @qwhelan @sbiner @davidcaron @raquelalegre @Balinus @ludwiglierhammer @dougiesquire @marielabonte @Beauprel @JamieJQuinn @cehbrecht @JeremyFyke @agstephens @malngu @clairbarnes @Ouranosinc/xclim-core
This paper is in the final stages of the review (congrats!) I wanted to confirm with you all that your ORCID numbers and affiliations are correct. If everything is fine, please just give a 👍 to this post, otherwise please leave a comment!
Thanks again!

Not sure you need my ORCID and affiliation, but in case you do, here it is: https://orcid.org/0000-0002-1516-6834. Affiliation: UK Centre for Ecology and Hydrology, Wallingford, UK. Thanks!

Just to let you know, I think I have spotted a typo in one of the names (an extra 's'): Gabriel Rondeau-Genessse

@JeremyFyke
Copy link
Contributor

Hi, my ORCID is 0000-0002-4522-3019. Thanks for including me!

@github-actions github-actions bot added the docs Improvements to documenation label May 17, 2023
@malngu
Copy link

malngu commented May 18, 2023

ATTN: @jwenfai @qwhelan @sbiner @davidcaron @raquelalegre @Balinus @ludwiglierhammer @dougiesquire @marielabonte @Beauprel @JamieJQuinn @cehbrecht @JeremyFyke @agstephens @malngu @clairbarnes @Ouranosinc/xclim-core

This paper is in the final stages of the review (congrats!) I wanted to confirm with you all that your ORCID numbers and affiliations are correct. If everything is fine, please just give a 👍 to this post, otherwise please leave a comment!

Thanks again!

@Zeitsperre Minor change if still possible: My correct affiliation is "UK Centre for Ecology & Hydrology (UKCEH)". Sorry, hadn't spotted it earlier. Don't worry if too late to change.

@Zeitsperre
Copy link
Collaborator Author

@malngu The edit is being added in now. Just under the wire!

@Zeitsperre Zeitsperre requested review from huard and aulemahal May 19, 2023 15:17
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui monsieur!

@Zeitsperre Zeitsperre changed the title JOSS application Add JOSS Article, Review badge and Citation information May 19, 2023
@Zeitsperre Zeitsperre merged commit 6c6d473 into master May 19, 2023
@Zeitsperre Zeitsperre deleted the joss_submission branch May 19, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation help wanted Extra attention is needed information For development/intsructional purposes priority Immediate priority standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PyOpenSci] Submit xclim to the Journal of Open Source Software