Allow passing multi-index dimension to spatial_analogs #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dist_dim`. `api_break`: `dist_dim` does not support sequence of dimensions. Users are expected to do the stacking themselves
aulemahal
requested changes
Jun 29, 2021
There was a problem hiding this comment.
Thanks!
We might have had a misunderstanding, the dimension to rename is the dist one. Observations are along this one, while "indices" or "variables" along the other one (which was indices before). It doesn't really make sense to have a different number of variables when comparing, but it's ok to have a different number of observations!
|
Wait, are you saying that for all that time, the code imposed target and candidate to have the same number of obs ? |
|
Haha, yes. |
|
Well, this shows it hasn't been used much so far... I think I've fixed it now. |
aulemahal
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion (major / minor / patch)has been called on this branchgit push --tags)What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Yes,
dist_dimwill not accept lists of dimensions anymore. Users are expected to create multi-indexes themselves.Other information: