Use HMAC SHA-256 with configurable amount of rounds to generate seed #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for HD wallet, also show the generated seed in WIF format.
ok2
changed the title
|
Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change coinb.in uses the same mechanism to generate seed from a passphrase like https://bip32.org: 50000 rounds of HMAC SHA-256 encryption.
The amount of rounds is configurable and the value
0results in the same mechanism as before for compatibility. The generated seed is also shown in WIF format, which is also withbitcoin-clicompatible. It is possible now to generate the same wallet usingbitcoin-cli sethdseed true <seed_wif>command in bitcoin core.To be really fully compatible with
bitcoin-cli, the fix in #228 pull request is also required.