(Web) FEAT: Can select image from clipboard using paste command #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keeps an unified way to represent image for all platforms - Removes platform checking requirements
- Can use 'paste' cmd (i.e. ctrl + v) to select image from the clipboard
- No need to check if list is empty to execute 'for-in' loop
Not able to upload image to cloud storage due missing mimeType - Setting mimeType from retrieved files into a var - If image selected from clipboard set mimeType to 'image/jpeg'
- Showing 'Icons.broken_image' instead of PlaceHolder for image error
Gallery selected image has diff result from clipboard or dropped image - Reduced image compression to match clipboard and dropped images
selected image gets previous image mimetype sometimes
|
Checked on both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
ctrl + vChanges
Uint8Listinstead ofXFileResolves #14