1.22.0 #902
Merged
1.22.0 #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That only has the parent path and rename
Do not try catch anymore This would cause some addon devs to just ignore an error when they really shouldn't. Now it will show the body where this error occurs since the error gets handled higher up.
or else end times doesn't work
This reverts commit 23feed8.
## Bug fixes - Slides are now loaded in the background instead of freezing your game. They were supposed to do this before, but clay wrote the code wrong and none of us caught it until now. (Fixes #812)
Will explode if the cache is wrong. Now the black screen loading time is like 5 seconds longer but the slide reels are then done loading instead of popping in over the course of 2 minutes. (EOTP)
- [ ] test with mods - [x] evacuation - [x] daylight savings - [ ] whatever the one xen found that flung you off the planet - [ ] other mods with tidally locked body spawn points
## Improvements - Setting `parentPath` will be more robust on most props Kinda worried about the overhead on this, do we think using `Find` to look for the parent is expensive? We'd be doing it for every prop ever and in most cases it will not matter.
## Major features - Added `GlobalMusic` module to system config (change end times, bramble dimension, and final end times music) (Resolves #894) ## Bug fixes - Fixed global bramble music not playing because all dimensions have an ambient audio volume
…ssel (#908) ## Bug fixes - No more infinite load when warping back to Outer Wilds system with vessel
JohnCorby
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major features
GlobalMusicmodule to system config (change end times, bramble dimension, and final end times music) (Resolves ability to add custom end times #894)Improvements
parentPathwill be more robust on most props (retries the build operation until it finds the parent)Bug fixes