Rocket 5.0 release updates #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and version to be one patch level higher (the outer interface didn't change).
Rocket 5 0 updates
Owez
requested changes
Dec 24, 2023
|
Sorry I missed this email, I'll make the change as soon as possible.
…On Sun, Dec 24, 2023, 4:33 AM Owen Griffiths ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In Cargo.toml
<#8 (comment)>:
> @@ -1,7 +1,7 @@
[package]
name = "rocket-basicauth"
description = "A high-level basic access authentication request guard for Rocket.rs"
-version = "2.1.1"
+version = "2.1.2"
Could you bump the version to 3 thanks, will be a breaking change
—
Reply to this email directly, view it on GitHub
<#8 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJWU3MURCYHYRXUBLLJR36TYLAHITAVCNFSM6AAAAABBAD7Y5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJVGU2TSMJWGM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Owez
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to support the change of Outcome so that Future has an error code and that the Outcome enum value isn't Failure it is Error.