Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shareable https url #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding shareable https url #51

wants to merge 1 commit into from

Conversation

alhdo
Copy link

@alhdo alhdo commented Mar 5, 2024

User can share automatically have a share url by adding --share to run command

@trzy
Copy link
Contributor

trzy commented Mar 8, 2024

I need to find some time this weekend to review this. Can you describe the intended operation?

@alhdo
Copy link
Author

alhdo commented Mar 8, 2024

Sure.
The point is to always have a HTTPS endpoint easily. The same way with gradio app you have shareable url like xxxxx.gradio.live. My PR is to integrate that shareable url features like gradio. When you start the app it expose the api with https . So http://localhost:8000 -> https://xxxxx.live.owlai.dev.

With this PR no need to add custom certificate to the mobile app or allow specific ip and avoid also trouble with accessing bluetooth and microphone over insecure protocole which modern browser does not like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants