DAS-7055, DAS-7064 Improve feedback errors for missing fields in report forms #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicavi
commented
Oct 4, 2021
| @@ -30,7 +32,7 @@ const filterOutEnumErrors = (errors, schema) => errors // filter out enum-based | |||
| }, schema); | |||
| } | |||
|
|
|||
| return !!match && !match.enum; | |||
| return !!match || match?.enum?.length; | |||
There was a problem hiding this comment.
This was causing for some required fields to not show an error
JoshuaVulcan
requested changes
Oct 6, 2021
JoshuaVulcan
requested changes
Oct 9, 2021
luixlive
reviewed
Oct 12, 2021
src/ReportForm/ReportFormBody.js
Outdated
| @@ -8,14 +8,16 @@ import styles from './styles.module.scss'; | |||
|
|
|||
| const additionalMetaSchemas = [draft4JsonSchema]; | |||
|
|
|||
| const getLinearErrorPropTree = (errorProperty) => { | |||
| return errorProperty.replace(/'|\.properties|\[|\]|\.enumNames|\.enum/g, '.') | |||
There was a problem hiding this comment.
Maybe we can create a constant for the regex, using an explicit name that explains the purpose of it. This way it would be easier to know what we are trying to replace here.
| @@ -70,7 +70,8 @@ describe('Error messages', () => { | |||
| expect(expandedAccordion).toBeTruthy(); | |||
|
|
|||
| userEvent.click(detailsButton); | |||
| expect(screen.getByRole('menuitem', { expanded: false })).toBeTruthy(); | |||
| notExpandedAccordion = screen.getByRole('menuitem', { expanded: false }); | |||
| expect(notExpandedAccordion).toBeTruthy(); | |||
JoshuaVulcan
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://allenai.atlassian.net/browse/DAS-7055
Evidence