Gundi 3719 v1 #34
Closed
Gundi 3719 v1 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Task GUNDI-3719 · Integration with Bluetrax |
marianobrc
reviewed
Nov 20, 2024
| unit_id: str | ||
| user_id: str | ||
| asset_id: str | ||
| currentLoc: dict |
There was a problem hiding this comment.
minor: we could use an alias so the field name can be snake_case to be PEP8 compliant
https://docs.pydantic.dev/1.10/usage/model_config/#alias-precedence
marianobrc
reviewed
Nov 20, 2024
app/bluetrax.py
Outdated
| return None | ||
|
|
||
| if __name__ == "__main__": | ||
| auth_result = asyncio.run(authenticate("securityadmin@loisaba.com", "Nanyorryang")) |
There was a problem hiding this comment.
It looks like credentials were accidentally committed?
marianobrc
reviewed
Nov 20, 2024
Comment on lines
+26
to
+28
| await self.db_client.setex( | ||
| f"integration_state.{integration_id}.{action_id}.{source_id}", | ||
| 7*86400, |
There was a problem hiding this comment.
Usually, the state is persistent but I see we want it to expire after some days here. I'd like to know more about this use case so we can add proper support for it in the template.
chrisdoehring
force-pushed
the
gundi-3719-v1
branch
from
a556bb9 to
f7f7d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial action runner for Bluetrax.
GUNDI-3719