Skip to content

Commit

Permalink
Remove (DOM)TransactionChainListener
Browse files Browse the repository at this point in the history
opendaylight/mdsal@82d4900
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
  • Loading branch information
Tobianas committed Mar 7, 2024
1 parent baff93d commit 2b4be02
Showing 1 changed file with 20 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@

package io.lighty.gnmi.southbound.mountpoint.broker;

import com.google.common.collect.ClassToInstanceMap;
import com.google.common.collect.ImmutableClassToInstanceMap;
import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.ListenableFuture;
import io.lighty.gnmi.southbound.mountpoint.ops.GnmiGet;
import io.lighty.gnmi.southbound.mountpoint.ops.GnmiSet;
import io.lighty.gnmi.southbound.mountpoint.transactions.ReadOnlyTx;
import io.lighty.gnmi.southbound.mountpoint.transactions.ReadWriteTx;
import io.lighty.gnmi.southbound.mountpoint.transactions.WriteOnlyTx;
import java.util.concurrent.Executor;
import org.eclipse.jdt.annotation.NonNull;
import org.opendaylight.mdsal.dom.api.DOMDataBrokerExtension;
import org.opendaylight.mdsal.dom.api.DOMDataTreeReadTransaction;
import org.opendaylight.mdsal.dom.api.DOMDataTreeReadWriteTransaction;
import org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction;
import org.opendaylight.mdsal.dom.api.DOMTransactionChain;
import org.opendaylight.mdsal.dom.api.DOMTransactionChainListener;
import org.opendaylight.mdsal.dom.spi.PingPongMergingDOMDataBroker;
import org.opendaylight.yangtools.yang.common.Empty;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -39,7 +39,7 @@ public GnmiDataBroker(final GnmiGet getProvider, final GnmiSet setProvider) {
}

@Override
public @NonNull DOMTransactionChain createTransactionChain(DOMTransactionChainListener listener) {
public @NonNull DOMTransactionChain createTransactionChain() {
return new DOMTransactionChain() {
@Override
public DOMDataTreeReadTransaction newReadOnlyTransaction() {
Expand All @@ -51,6 +51,21 @@ public DOMDataTreeReadWriteTransaction newReadWriteTransaction() {
return GnmiDataBroker.this.newReadWriteTransaction();
}

@Override
public void addCallback(FutureCallback<Empty> callback) {
DOMTransactionChain.super.addCallback(callback);

This comment has been minimized.

Copy link
@rovarga

rovarga Mar 7, 2024

Contributor

what is this supposed to do?

This comment has been minimized.

Copy link
@Tobianas

Tobianas May 16, 2024

Author Contributor

Resolved

c5ae862

This comment has been minimized.

Copy link
@ihrasko

ihrasko May 20, 2024

Collaborator

ACK

}

@Override
public void addCallback(FutureCallback<Empty> callback, Executor executor) {
DOMTransactionChain.super.addCallback(callback, executor);
}

@Override
public @NonNull ListenableFuture<Empty> future() {
return createMergingTransactionChain().future();

This comment has been minimized.

Copy link
@rovarga

rovarga Mar 7, 2024

Contributor

this looks wrong. can GNMI even support the notion of a transaction chain?

This comment has been minimized.

Copy link
@Tobianas

Tobianas May 16, 2024

Author Contributor

Resolved

c5ae862

This comment has been minimized.

Copy link
@ihrasko

ihrasko May 23, 2024

Collaborator

ACK

}

@Override
public DOMDataTreeWriteTransaction newWriteOnlyTransaction() {
return GnmiDataBroker.this.newWriteOnlyTransaction();
Expand All @@ -63,11 +78,6 @@ public void close() {
};
}

@Override
public @NonNull ClassToInstanceMap<DOMDataBrokerExtension> getExtensions() {
return ImmutableClassToInstanceMap.of();
}

@Override
public DOMDataTreeReadTransaction newReadOnlyTransaction() {
return new ReadOnlyTx(gnmiGet);
Expand Down

0 comments on commit 2b4be02

Please sign in to comment.