Separate blocking shutdown

Separate unlocking CountDownLatch to shutdownBlocking() to avoid
interaction with CountDownLatch for users who do not call blocking
start.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

lighty-core/lighty-controller/src/main/java/io/lighty/core/controller/api/AbstractLightyModule.java

@@ -189,11 +189,24 @@ public synchronized ListenableFuture<Boolean> shutdown() {
         return shutdownFuture;
     }
 
+    /**
+     * Invoke blocking shutdown after blocking start
+     * Release CountDownLatch locking this thread and shutdown.
+     * @param duration duration to wait for shutdown to complete
+     * @param unit {@link TimeUnit} of {@code duration}
+     * @return {@code boolean} indicating shutdown sucess
+     * @deprecated Use {@code shutdown()} or {@code shutdown(duration, unit)} instead in case you want blocking shutdown.
+     */
+    @Deprecated(forRemoval = true)
+    public final boolean shutdownBlocking(final long duration, final TimeUnit unit) {
+        shutdownLatch.countDown();
+        return shutdown(duration, unit);
+    }
+
     @SuppressWarnings("IllegalCatch")
     @Override
     public final boolean shutdown(final long duration, final TimeUnit unit) {
         try {
-            shutdownLatch.countDown();
             final var stopSuccess = shutdown().get(duration, unit);
             if (stopSuccess) {
                 LOG.info("LightyModule {} stopped successfully!", getClass().getSimpleName());