Add notifications to CommunityRestConf #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrasko
requested changes
Jan 12, 2024
...ty/src/main/java/io/lighty/modules/northbound/restconf/community/impl/CommunityRestConf.java
Outdated
Show resolved
Hide resolved
ihrasko
force-pushed
the
mainNotif
branch
2 times, most recently
from
2f5be89
to
78926e9
Compare
Tobianas
force-pushed
the
mainNotif
branch
6 times, most recently
from
7d75b3a
to
9f4954f
Compare
Tobianas
force-pushed
the
mainNotif
branch
3 times, most recently
from
dade827
to
e581ead
Compare
Register servlet for notifications on <basePath>/notif for both websockets and SSE in CommunityRestConf module. Note that lighty.io provides no configurable option to choose from websockets or SSE. SSE is hard-coded default. Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Because base path is hard-coded in ODL, we need to make this application use /rests base. This commit should be reverted after NETCONF-1218 is resolved and implemented. Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
ihrasko
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for listening on device notifications over SSE into
CommunityRestConfmodule.The functionality requires that application configuration is using base path set to
restsas is OpenDaylight default due to https://jira.opendaylight.org/browse/NETCONF-1218.When correctly configured all applications based on
CommunityRestConfcan be used for notifications listening. For now we recommends to uselighty-community-restconf-netconf-app.