Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt 21.1.0 ODL MRI versions #2064

Closed
wants to merge 34 commits into from

Conversation

Tobianas
Copy link
Contributor

@Tobianas Tobianas commented Nov 6, 2024

  • odlparent-14.0.4
  • infrautils-7.0.4
  • yangtools-14.0.5
  • mdsal-14.0.4
  • controller-10.0.4
  • aaa-0.20.3
  • netconf-8.0.3
  • bgpcep-0.22.6

Tobianas and others added 30 commits October 18, 2024 10:02
JIRA: LIGHTY-320
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
JIRA: LIGHTY-320
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
JIRA: LIGHTY-320
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
JIRA: LIGHTY-320
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
JIRA: LIGHTY-320
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
(cherry picked from commit 3f01771)
With the release of Lighty.io 21
we drop support for version 19.

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit f2fbf6f)
https://junit.org/junit5/docs/5.11.2/release-notes/#release-notes-5.11.2

JIRA: LIGHTY-332
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
lighty.io 21 uses Java 21.
Use eclipse-temurin-21 in simulator Dockerfile.

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 67f747f)
Set maven.compiler.release in Spring example to 21.

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit c377e01)
Update checks in start-controller.sh to require Java 21.

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 79ea518)
Set maven.compiler.release in log4j-config to 21.

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 269cabb)
https://github.com/fabric8io/docker-maven-plugin/releases/tag/v0.45.1

Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
(cherry picked from commit ecadcf2)
Snyk has created this PR to upgrade io.grpc:grpc-netty from 1.66.0
to 1.67.1.

https://github.com/grpc/grpc/releases/tag/v1.67.1
https://github.com/grpc/grpc/releases/tag/v1.67.0

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit e441ec8)
https://github.com/spring-projects/spring-boot/releases/tag/v3.3.5

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 860ac30)
https://github.com/casbin/jcasbin/releases/tag/v1.71.0

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 321d8bc)
Call shutdownLatch.countDown() on blocking shutdown only,
not in asynchronous shutdown() method.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 61e67ea490f73000d4e827367259b962e8e0e993)
Remove sleeps() call from LightyModuleTest. Use blocking get() instead.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 414c84b)
Rename LightyControllerMountPointTetst.java to
LightyControllerMountPointTest.java.

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit e14f522)
Ensure that we wait until lighty.io controller is started
or stopped.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit f82ca5f)
Do not mix blocking shutdown after non-blocking start which
does not acquire count down latch.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit bb91d47)
Increase timeout for start/shutdown in FileToDatastoreUtilsTest
in order to avoid timeouts during verify jobs.

60 seconds timeout corresponds with default module timeout as
set in ModulesConfig class.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit c4d7940)
Deparecate practically unused LightyModule#startBlocking method
which helps us to get rid of CountDownLatch in AbstractLightyModule.

This method seems to be mixing concepts of using Future and
CountDownLatch synchronisation tools. IMO there is no need to block
start method.

Additionally, there were some unusual usages in tests. They were
trying to invoke a blocking call and wrap its result into Future.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 187f7f6)
Separate unlocking CountDownLatch to shutdownBlocking() to avoid
interaction with CountDownLatch for users who do not call blocking
start.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Run test during build in single thread to avoid
"address already in use" issues which can be caused by parallel test
execution.

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit a80868f)
Fix check-style in AbstractLightyModule class.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Add timeout to all shutdown calls in test classes.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit b65dd3d)
ihrasko and others added 2 commits October 31, 2024 14:47
Clean up various code style issues in tests.

JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit eb36f82)
- odlparent-14.0.4
- infrautils-7.0.4
- yangtools-14.0.5
- mdsal-14.0.4
- controller-10.0.4
- aaa-0.20.3
- netconf-8.0.3
- bgpcep-0.22.6

JIRA: LIGHTY-339
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
@Tobianas Tobianas closed this Nov 6, 2024
@Tobianas Tobianas reopened this Nov 6, 2024
@Tobianas Tobianas marked this pull request as ready for review November 6, 2024 11:39
Use JaxRsOpenApi based on injected OpenApiService instance:
opendaylight/netconf@2055cd2

JIRA: LIGHTY-339
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Add range restriction for backoff-multiplier:
opendaylight/netconf@6b80ae0#diff-66ffe71b2608193263cdcf5b4baf22a9166ee7ed93161637caffef6a3fba7f37

JIRA: LIGHTY-339
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
@ihrasko ihrasko changed the base branch from 21.x to main November 7, 2024 14:34
@ihrasko ihrasko closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants