Bump checkstyle to 10.18.2 #2066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: LIGHTY-294 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit e7a2725)
Start next development iteration towards lighty.io 20.1.0. Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
JIRA: LIGHTY-294 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 76a31ff)
This timeout caused tests to be unreliable an inconsistent. JIRA: LIGHTY-299 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 70346b0)
The addCallback methods do not need to be implemented since they are default. Also change the future method to return completed future since it's not chained. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 24c3dbe)
Just use .namespace() to return namespace, and if namespace is null, just use name. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 04d6fcd)
No need to import these classes when ImmutableNodes can beused for same purpose. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 8b7fe7f)
This service is no longer required as a part of this rework: opendaylight/controller@9917911 JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 33b9022)
Use these changes to modernize RPC implementation registration: opendaylight/lispflowmapping@27c0004 JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 57e185e)
There is no need to bind it again, since it is already bound from DOMSchemaService. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 600b033)
Reformat the code a little to improve its readability. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 6f16e5e)
Adopt: - odlparent-13.1.2 - infrautils-6.0.8 - yangtools-13.0.5 - mdsal-13.0.3 - controller-9.0.3 - aaa-0.19.4 - netconf-7.0.5 - bgpcep-0.21.5 JIRA: LIGHTY-302 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 85d16a5)
Rename these components according to: opendaylight/mdsal@c4c6619 JIRA: LIGHTY-302 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit f7bdd24)
The usage of TokenStore was removed with OAuth2 implementations. https://git.opendaylight.org/gerrit/c/aaa/+/104968 JIRA: LIGHTY-302 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 152d4e5)
Introduce these parameters as a result of: opendaylight/netconf@4e2e5be#diff-8eddc437230f04d9d277415bdf718dd998114e916aea8bfcba5a2f9bb69e2174R72 and: opendaylight/netconf@2bb1482#diff-8eddc437230f04d9d277415bdf718dd998114e916aea8bfcba5a2f9bb69e2174R71 Let's currently just hardcode these parameters and resolve their configuration in LIGHTY-305. JIRA: LIGHTY-302 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 9719f72)
Adjust imports based on: opendaylight/netconf@68f748b JIRA: LIGHTY-302 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 7a604dc)
One constructor of this class got removed, lets just use a workaround for this test where the localRpcs parameter is not required: opendaylight/netconf@b372a54#diff-7de3450feabdc63b9c2b21ce40182a3d784e788ae85c31927a36615f2e24080eL66 JIRA: LIGHTY-302 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 1a034c6)
Comment these tests out until YANGTOOLS-1575 is resolved. JIRA: LIGHTY-303 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit c1c5286)
https://checkstyle.org/releasenotes.html#Release_10.16.0 JIRA: LIGHTY-304 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit fc94ad8)
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12353548 JIRA: LIGHTY-304 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit b4f87c1)
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12354551 JIRA: LIGHTY-304 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 84b0827)
https://github.com/testng-team/testng/releases/tag/7.10.2 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 1780357)
Adopt: odlparent-13.1.3 infrautils-6.0.9 yangtools-13.0.6 mdsal-13.0.4 JIRA: LIGHTY-309 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 19e85c3)
https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-dependencies JIRA: LIGHTY-306 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 002b153)
Snyk has created this PR to upgrade io.grpc:grpc-netty from 1.63.0 to 1.64.0. https://github.com/grpc/grpc-java/releases/tag/v1.64.0 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 0b36799)
https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-dependencies/3.3.0 JIRA: LIGHTY-303 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 46424a9)
https://github.com/spotbugs/spotbugs/releases/tag/4.8.4 https://github.com/spotbugs/spotbugs/releases/tag/4.8.5 https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.4.0 https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.5.0 JIRA: LIGHTY-303 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit a598163)
https://github.com/mojohaus/build-helper-maven-plugin/releases/tag/3.6.0 JIRA: LIGHTY-303 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit a577039)
JIRA: LIGHTY-319 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
JIRA: LIGHTY-319 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
JIRA: LIGHTY-319 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
JIRA: LIGHTY-319 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Snyk has created this PR to upgrade commons-io:commons-io from 2.16.1 to 2.17.0. https://github.com/apache/commons-io/releases/tag/rel%2Fcommons-io-2.17.0 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 1db56fe)
Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.24.0 to 2.24.1. https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-24-1 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 282670c)
https://junit.org/junit5/docs/5.11.2/release-notes/#release-notes-5.11.2 JIRA: LIGHTY-332 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12355072 JIRA: LIGHTY-332 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12355065 JIRA: LIGHTY-332 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.6.3 https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.6.4 JIRA: LIGHTY-332 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
https://github.com/fabric8io/docker-maven-plugin/releases/tag/v0.45.1 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit ecadcf2)
Snyk has created this PR to upgrade io.grpc:grpc-netty from 1.66.0 to 1.67.1. https://github.com/grpc/grpc/releases/tag/v1.67.1 https://github.com/grpc/grpc/releases/tag/v1.67.0 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit e441ec8)
Snyk has created this PR to upgrade org.casbin:jcasbin from 1.55.0 to 1.67.0. https://github.com/casbin/jcasbin/releases/tag/v1.67.0 https://github.com/casbin/jcasbin/releases/tag/v1.66.0 https://github.com/casbin/jcasbin/releases/tag/v1.65.0 https://github.com/casbin/jcasbin/releases/tag/v1.64.0 https://github.com/casbin/jcasbin/releases/tag/v1.63.0 https://github.com/casbin/jcasbin/releases/tag/v1.62.0 https://github.com/casbin/jcasbin/releases/tag/v1.61.0 https://github.com/casbin/jcasbin/releases/tag/v1.60.0 https://github.com/casbin/jcasbin/releases/tag/v1.59.0 https://github.com/casbin/jcasbin/releases/tag/v1.58.0 https://github.com/casbin/jcasbin/releases/tag/v1.57.0 https://github.com/casbin/jcasbin/releases/tag/v1.56.0 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 38b2d8c)
https://github.com/spring-projects/spring-boot/releases/tag/v3.3.5 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 860ac30)
https://github.com/casbin/jcasbin/releases/tag/v1.71.0 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 321d8bc)
Call shutdownLatch.countDown() on blocking shutdown only, not in asynchronous shutdown() method. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 61e67ea490f73000d4e827367259b962e8e0e993)
Remove sleeps() call from LightyModuleTest. Use blocking get() instead. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 414c84b)
Rename LightyControllerMountPointTetst.java to LightyControllerMountPointTest.java. Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit e14f522)
Ensure that we wait until lighty.io controller is started or stopped. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit f82ca5f)
Do not mix blocking shutdown after non-blocking start which does not acquire count down latch. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit bb91d47)
Increase timeout for start/shutdown in FileToDatastoreUtilsTest in order to avoid timeouts during verify jobs. 60 seconds timeout corresponds with default module timeout as set in ModulesConfig class. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit c4d7940)
Deprecate practically unused LightyModule#startBlocking method which helps us to get rid of CountDownLatch in AbstractLightyModule. This method seems to be mixing concepts of using Future and CountDownLatch synchronisation tools. IMO there is no need to block start method. Additionally, there were some unusual usages in tests. They were trying to invoke a blocking call and wrap its result into Future. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 187f7f6)
Separate unlocking CountDownLatch to shutdownBlocking() to avoid interaction with CountDownLatch for users who do not call blocking start. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 473bb06)
Run test during build in single thread to avoid "address already in use" issues which can be caused by parallel test execution. Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit a80868f)
Add timeout to all shutdown calls in test classes. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit b65dd3d)
Clean up various code style issues in tests. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit eb36f82)
https://checkstyle.org/releasenotes.html#Release_10.18.2 JIRA: LIGHTY-341 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit ea1758b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://checkstyle.org/releasenotes.html#Release_10.18.2
JIRA: LIGHTY-341
Signed-off-by: tobias.pobocik tobias.pobocik@pantheon.tech
(cherry picked from commit ea1758b)