Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a data type #207

Closed
HTsybenko opened this issue Mar 4, 2024 · 4 comments
Closed

Deleting a data type #207

HTsybenko opened this issue Mar 4, 2024 · 4 comments
Assignees

Comments

@HTsybenko
Copy link

Non-structural data types (Measurements, samples, etc.) can be deleted.
This does not remove the items of this type from the project, however, the tables of the deleted data types cannot be accessed anymore, which might make it more difficult to curate.

What would be the correct way if a data type is deleted - move the files of such category to unidentified?

@HTsybenko HTsybenko added the question Further information is requested label Mar 4, 2024
@SteffenBrinckmann
Copy link
Contributor

Same as #143: I don't know where the fix hangs in the development (aka before the 2.5.0b3), but the code was integrated #198.
Please wait for the next beta to verify

  • it is 'moved' to unidentified.

@SteffenBrinckmann SteffenBrinckmann added PR created and removed question Further information is requested labels Mar 5, 2024
@HTsybenko
Copy link
Author

After the removal of the data type, the items of that type are moved to "unidentified" table.

The unidentified table also has the following look and includes the PASTA-related metadata (likely not intended):
Screenshot from 2024-03-15 11-39-12

@SteffenBrinckmann
Copy link
Contributor

@HTsybenko Your call since this is not a crashing bug and I currently work on the corrosion stuff and cannot test/verify/debug it:

  • do you want to pause the release of 2.5.0 until this is fixed
  • do you want to move it to 2.6 or so

@SteffenBrinckmann
Copy link
Contributor

OK, I tried it myself, and it works as intended. For you not, clearly.
The colums of the unidentified, is addressed in #170 and I added a comment there, that we check if the colums remain correct after deleting an document-type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants