Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project visibility issues #35

Closed
HTsybenko opened this issue Sep 13, 2023 · 5 comments
Closed

Project visibility issues #35

HTsybenko opened this issue Sep 13, 2023 · 5 comments
Assignees

Comments

@HTsybenko
Copy link

Issues related to the visibility options for the projects:

  • Open a project in a project view - click "visibility" button on the top right - click "hide/show hidden subitems"- the entire project disappears from GUI.
  • The “hide/show entire project” option seems to not do anything.
  • "Minimize-maximize subitems" option sometimes does not work- needs to be clicked twice to minimize, clicking more to maximize does not do anything.
  • All selected visibility options except for the problematic “hide/show hidden subitems” function only until the project is reopened. Then, the options are returned to default.
@SteffenBrinckmann
Copy link
Contributor

Hey,

  • there was a code change and by accident two options were intermixed, first two bullet points are due to it.
  • indeed, some visibility changes are permanent (hide/show), the rest is temporary until the view is recreated
  • in addition to the intermixing, there was also another terrible mistake due to the code change.

Bugs should be repaired by #44

If you disagree with some of the design ideas regrading visibility and their permanence, please mention them

@jmurugan-fzj
Copy link
Contributor

jmurugan-fzj commented Sep 18, 2023

@SteffenBrinckmann When I tested the PR branch, I observed the following, I had a single example project in my setup for the testing purpose

  1. Clicked Visibility -> Hide/Show Project Details
  • This toggles the display of the project information
    image
  1. Clicked Visibility -> Hide/Show Hidden Sub Item
  • This step seems to do nothing, just noticed that if at all "data files" are expanded, the seem to collapse, no other noticed effect happens in UI
  1. Clicked Visibility -> Minimize/Maximize Sub Item
  • This seems to minimize all sub items, but they seem to be minimized all the items, cannot be maximized there after by subsequent clicks. No matter, what I do the UI looks like as below
  • image
  1. Clicked Visibility -> Hide/Show Entire project
  • This is quite tricky, when I do the first click, everything disappears from UI and cannot have the possibility to unhide the hidden project. I tried to click on all the items in the Lists menu (Lists >> Projects, Lists >> Measurements, etc..), everything went empty. Is this the expected behavior?
  • image
  • image
  • image

Also after all the above operations, I tried to relaunch the PASTA app and then it displays the following message:
image

Are these the expected behavior for the actions? I was a bit confused, when trying to verify the fix done as part of this issue..

@SteffenBrinckmann
Copy link
Contributor

I have to look into 3 and into the dialog opening. The latter, I have to check on your computer.

Everything else is working as designed.
Hiding is permanent and has to be manually undone=shown
Minimizing is temporary for getting better overview.
It is obvious that we better document this

@jmurugan-fzj
Copy link
Contributor

@SteffenBrinckmann What is the scope of this bug fix? It's a must that we should be very specific When we close this bug, it should be clear that which all are fixed as part of this and which all are pending! If the effort is a lot, we could split this into multiple issues and address them separately...

@HTsybenko
Copy link
Author

The visibility options seem to function at this point, and the “hide/show entire project” is not intermixed with the "hide/show hidden subitems" anymore. Therefore, I close this issue.

I still have a number of points to be discussed regarding the overall user experience with the visibility options, for which I will create a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants