Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

通过接入MCIM API以支持简介翻译 #242

Merged
merged 13 commits into from
Feb 13, 2025
Merged

通过接入MCIM API以支持简介翻译 #242

merged 13 commits into from
Feb 13, 2025

Conversation

JustQiyi
Copy link

Close #175
还有一些不足的地方，例如无法关闭此功能等等，先开个PR。

@JustQiyi JustQiyi marked this pull request as draft February 11, 2025 11:17
@wyc-26
Copy link

wyc-26 commented Feb 11, 2025

image
啊这……效果看上去不是很好
要不搞成点开之后有一个翻译按钮的那种

@tangge233 tangge233 added the 🚧 正在处理 开发者正在调查或处理该内容 label Feb 11, 2025
@JustQiyi
Copy link
Author

JustQiyi commented Feb 11, 2025 •
edited by wyc-26
Loading

[image]
啊这……效果看上去不是很好
要不搞成点开之后有一个翻译按钮的那种

豪，我改一下

@wyc-26 wyc-26 marked this pull request as ready for review February 13, 2025 13:05
@wyc-26 wyc-26 self-requested a review February 13, 2025 13:05
@JustQiyi
Copy link
Author

我写的时候有点蒙了，在获取译文的时候会阻塞线程

@tangge233
Copy link
Member

我写的时候有点蒙了，在获取译文的时候会阻塞线程

可以使用 RunInNewThread 和 RunInUi 组合（

wyc-26
wyc-26 requested changes Feb 13, 2025
View reviewed changes
Copy link

@wyc-26 wyc-26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么按了按钮之后会卡一下才会显示出正在翻译的提示……？
卡一下我能理解，是等待翻译，但是为什么正在翻译的提示是翻译后才会显示的（

@wyc-26
Copy link

wyc-26 commented Feb 13, 2025

我写的时候有点蒙了，在获取译文的时候会阻塞线程

是这样的（

@wyc-26 wyc-26 added this to the 2.10.4 milestone Feb 13, 2025
@JustQiyi
Copy link
Author

我写的时候有点蒙了，在获取译文的时候会阻塞线程

可以使用 RunInNewThread 和 RunInUi 组合（

还是没弄明白tat

@JustQiyi JustQiyi requested a review from wyc-26 February 13, 2025 13:47
wyc-26
wyc-26 requested changes Feb 13, 2025
View reviewed changes
Copy link

@wyc-26 wyc-26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文符号 && 中英文之间的空格（

@PCL-Community PCL-Community deleted a comment from JustQiyi Feb 13, 2025
@JustQiyi
Copy link
Author

中英文符号 && 中英文之间的空格（

从API获取到的译文需要处理吗?

@wyc-26
Copy link

wyc-26 commented Feb 13, 2025

中英文符号 && 中英文之间的空格（

从API获取到的译文需要处理吗?

不必了，要不然会很麻烦的（
机翻毕竟是机翻么，还是有小瑕疵的

@JustQiyi JustQiyi requested a review from wyc-26 February 13, 2025 14:02
@JustQiyi JustQiyi changed the title 通过接入MCIM API以支持Mod简介翻译 通过接入MCIM API以支持简介翻译 Feb 13, 2025
wyc-26
wyc-26 approved these changes Feb 13, 2025
View reviewed changes
Copy link

@wyc-26 wyc-26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

彳亍

@wyc-26 wyc-26 merged commit fc56550 into PCL-Community:main Feb 13, 2025
4 checks passed
@wuliaodexiaoluo wuliaodexiaoluo added 👌 完成 处理完毕，将在下次更新后实装 and removed 🚧 正在处理 开发者正在调查或处理该内容 labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyc-26 wyc-26 wyc-26 approved these changes

Assignees
No one assigned
Labels
👌 完成 处理完毕，将在下次更新后实装
Projects
None yet
Milestone
2.10.4
Development

Successfully merging this pull request may close these issues.

支持 Mod 简介翻译
4 participants
@JustQiyi @wyc-26 @tangge233 @wuliaodexiaoluo