Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ESGF2-US logos; suggested text tweaks #1034

Merged
merged 7 commits into from
Jan 31, 2024

Conversation

durack1
Copy link
Collaborator

@durack1 durack1 commented Jan 30, 2024

@lee1043 @acordonez adding the ESGF2-US logos to both notebooks and some suggested tweaks for the secondary/supplementary notebook

@durack1 durack1 requested review from lee1043 and acordonez January 30, 2024 21:14
Copy link
Contributor

@lee1043 lee1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@durack1 Thank you for the tweak!

@lee1043 lee1043 added the demo label Jan 31, 2024
@lee1043 lee1043 merged commit d96030f into main Jan 31, 2024
5 checks passed
@lee1043 lee1043 deleted the 405_durack1_addESGF2-USLogoToSeaIceNotebook branch January 31, 2024 01:06
@durack1
Copy link
Collaborator Author

durack1 commented Jan 31, 2024

@lee1043 whoops, I should have tagged this "draft".. Still have to check logo sizes in the second notebook - I was trying to size things similarly, which meant upping the PCMDI size to 100px width

@durack1
Copy link
Collaborator Author

durack1 commented Jan 31, 2024

@lee1043 looks like the resizing messed things up a bit!
Screenshot 2024-01-30 at 6 06 18 PM

@lee1043 lee1043 restored the 405_durack1_addESGF2-USLogoToSeaIceNotebook branch January 31, 2024 02:08
@lee1043
Copy link
Contributor

lee1043 commented Jan 31, 2024

@durack1 sorry, I thought it was ready. I restored the branch and please feel free to continue working on that branch and let me know when it is ready.

@lee1043
Copy link
Contributor

lee1043 commented Jan 31, 2024

Screenshot 2024-01-30 at 9 27 15 PM

It looks okay on my end. I will delete the branch, but please feel free to reopen it if the issue still remain on your end.

@lee1043 lee1043 deleted the 405_durack1_addESGF2-USLogoToSeaIceNotebook branch January 31, 2024 05:28
@lee1043
Copy link
Contributor

lee1043 commented Jan 31, 2024

The issue fixed by #1038 and the change merged to the main.

@durack1
Copy link
Collaborator Author

durack1 commented Jan 31, 2024

@lee1043 yep this looks good to me now in main - using the nbviewer parsed versions
Screenshot 2024-01-31 at 5 43 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants