Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use open_dataset if single file #1042

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Use open_dataset if single file #1042

merged 7 commits into from
Feb 2, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Feb 1, 2024

Update xcdat_openxml.py to use open_dataset instead of open_mfdataset to save memory, considering discussions at #1041 (comment)

@lee1043 lee1043 self-assigned this Feb 2, 2024
@lee1043 lee1043 requested a review from acordonez February 2, 2024 01:50
@lee1043 lee1043 marked this pull request as ready for review February 2, 2024 01:50
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the mean climate notebook to test and all cases ran successfully without changing the metrics.

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 2, 2024

@acordonez thank you for checking on this!

@lee1043 lee1043 merged commit 8248733 into main Feb 2, 2024
5 checks passed
@lee1043 lee1043 deleted the lee1043-patch-1 branch February 2, 2024 17:24
@lee1043 lee1043 added this to the 3.3.1 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants