-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENSO on-the-fly plots #1199
ENSO on-the-fly plots #1199
Conversation
At the moment, CI failing might be caused by constraint to enso metrics version as 1.1.3 while it is yet to release. |
@acordonez when you get a chance, could you please run demo 6 with the PR to see if it run smoothly? |
@lee1043 I'm having some issues creating an environment that works. It looks like cmocean need to be added to dev.yml? And I'm getting the following error:
These are my matplotlib versions:
|
@acordonez thank you for pointing that out which is a great reminder! I missed adding it to dependency. I will add them to dev and ci yml files. |
@acordonez just added. Could you check if that resolves the issue? |
@lee1043 That solved the cmocean import issue but I am still getting this error when running enso_driver.py:
I tried using
I can keep looking into this but curious if you have any ideas. |
@acordonez thank you for testing. It looks like I have those libraries in my environment, which I suspect they might be dependency of something. Can you check your maplotlib version? Mine is 3.9.2.
If this continues to cause issue, can you try recreate your conda env using the dev.yml file using the following command, then install PMP, and run the notebook?
|
@lee1043
I did use I tried adding
|
@acordonez thank you, I was able to reproduce the issue on my end as well.
It looks like the issue is mostly from conflict between @yyplanton should we consider move to |
Updating ENSO plot to use |
For enso metrics, CLIVAR-PRP/ENSO_metrics#88 merged and new version tagged (v1.1.4). I am reassign this PR for PMP v3.8. |
@acordonez I think this PR is now ready for another round of review -- thank you for doing this! |
@lee1043 Just want to check, is it expected to get null values in the demo JSON results? For example:
|
@acordonez thank you for checking. Could you check if
|
@lee1043 Yes the two metrics values match. Otherwise this ran without issue for me. |
@acordonez nice, thank you! |
Addresses #1127.
Accompanied PR in ENSO metrics: CLIVAR-PRP/ENSO_metrics#82
Demo notebook update to include sample dive down plots.