pin to numpy < 2.1

PDAL · Sep 17, 2024 · 17d9b16 · 17d9b16
1 parent 9b8199f
commit 17d9b16
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/environment.yml b/.github/environment.yml
@@ -3,7 +3,7 @@ channels:
   - conda-forge
 dependencies:
   - scikit-build-core
-  - numpy
+  - numpy < 2.1
   - pdal
   - compilers
   - python

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -24,7 +24,7 @@ jobs:
       fail-fast: true
       matrix:
         os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
-        python-version: ['3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
 
     steps:
     - name: Check out

diff --git a/src/pdal/io/NumpyReader.cpp b/src/pdal/io/NumpyReader.cpp
@@ -142,6 +142,8 @@ PyArrayObject* load_npy_file(std::string const& filename)
 {
 
     PyObject *py_filename =  PyUnicode_FromString(filename.c_str());
+    if (!py_filename)
+        throw pdal::pdal_error(plang::getTraceback());
     PyObject *numpy_module = PyImport_ImportModule("numpy");
     if (!numpy_module)
         throw pdal::pdal_error(plang::getTraceback());