Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #124

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fixes #124

merged 2 commits into from
Jun 19, 2024

Conversation

Shalucik
Copy link
Member

@Shalucik Shalucik commented Jun 19, 2024 •
edited
Loading

Description

  • fix build not using version correctly
  • stack traces errors are now Unknown Warnings

Type of change

  • Bugfix

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@Shalucik Shalucik requested a review from RoelvandenBerg June 19, 2024 08:40
@Shalucik Shalucik merged commit 7fe3071 into master Jun 19, 2024
11 checks passed
@Shalucik Shalucik deleted the fixes branch June 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoelvandenBerg RoelvandenBerg RoelvandenBerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shalucik @RoelvandenBerg