Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird distribution on artboards #14

Closed
margaretgrobler opened this issue Feb 10, 2017 · 12 comments
Closed

Weird distribution on artboards #14

margaretgrobler opened this issue Feb 10, 2017 · 12 comments

Comments

@margaretgrobler
Copy link

When distributing a few duplicated layers (for instance a line shape) vertically, it places them all at the right interval apart, but in a seemingly random spot off the top of the artboard. I would expect them to be placed one after the other going downward. (PS: I am a newbie to Sketch so I hope this is not an app settings issue that I'm bugging you with, but I would find this plugin extremely useful if I can get this figured out).

@PEZ
Copy link
Owner

PEZ commented Feb 10, 2017

@margaretgrobler: I'm not sure I follow what the problem is. Do the selection of of layers you are distributing move as a whole on distribution?

@margaretgrobler
Copy link
Author

Yes @PEZ - it all jumps so that even the bottom layer out of the bunch is much higher (100px+) than where they all started. (Since they were duplicates to start out, they were all in the same spot originally - they 'jumped' up).

@PEZ
Copy link
Owner

PEZ commented Feb 10, 2017

@margaretgrobler: Which version of the plugin are you using? (You can see the version number under Plugins->Manage Plugins…).

@margaretgrobler
Copy link
Author

1.0.3.1. I am attaching three screenshots so you can see exactly what I am doing.
screen shot 2017-02-10 at 1 18 11 pm
screen shot 2017-02-10 at 1 19 15 pm
screen shot 2017-02-10 at 1 19 22 pm

@PEZ
Copy link
Owner

PEZ commented Feb 10, 2017

Thanks. I'm sort of able to reproduce it, and think that it might be a recently introduced bug. I have some investigation to do now. 😎

@margaretgrobler
Copy link
Author

Ok good. Thanks for being so responsive :)

@PEZ
Copy link
Owner

PEZ commented Feb 10, 2017

I think I could confirm that the bug is newly introduced. It was when I thought I had fixed the problem with distributing rotated layers…

Well, we can't have the plugin as broken as that so I have just now updated with a temporary version that retracts the fix for rotated layers. Please see if it fixes the problem you found for you as well. I'll leave this issue open until I have decided/figured out what to do about the two issues.

@margaretgrobler
Copy link
Author

The fix works! Thanks so much! 👍

@PEZ PEZ changed the title Placement of duplicated objects don't distribute vertically down Weird distribution on artboards Feb 11, 2017
@PEZ
Copy link
Owner

PEZ commented Feb 11, 2017

I changed the title of this issue, since it happens on artboards and not on a page without artboards. And, indeed, it was a result of fixing issue #10. I do hope I can find a way to close both these issues.

PEZ added a commit that referenced this issue Feb 11, 2017
This fixes #10 and #14. And also introduces a new issue with
non-pixel-aligned layers, see README for details.
@PEZ
Copy link
Owner

PEZ commented Feb 11, 2017

@margaretgrobler: I have now updated the plugin to both behave on an artboard and handle rotated layers. Can you help me confirm that the plugin works on artboards as you would expect? You will need to update to the latest version. I would completely understand if you don't want to risk your workflow, but I ask anyway, because there are so many different situations where the plugin will be used that I need more people than myself to scrutinise.

@PEZ
Copy link
Owner

PEZ commented Feb 12, 2017

@margaretgrobler: never mind. The fix for #10 had several other issues that I don't think are possible to deal with so I have reverted it.

Closing this issue as fixed.

@PEZ PEZ closed this as completed Feb 12, 2017
@margaretgrobler
Copy link
Author

@PEZ : My apologies for not being online this weekend to help. Thanks for your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants