Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing action attributes #135

Open
Pablete1234 opened this issue Aug 11, 2024 · 0 comments · May be fixed by #140
Open

Missing action attributes #135

Pablete1234 opened this issue Aug 11, 2024 · 0 comments · May be fixed by #140

Comments

@Pablete1234
Copy link
Member

<action> has both a filter and an untrigger-filter, the second filters if untrigger events (ie: when the filter of a trigger stops matching) is passed down to children. This behavior is completely undocumented but it is essentially the same idea as lend kits, where when filter passes you give the kit, and after filter stops passing you remove the kit. Given kits are actions, this works with them too.
The default for untrigger-filter is never tho, because it was added after actions and it would be a behavior change (if you had a kit it would now remove it while prior it wouldn't have).

<switch-scope> is essentially parsed as an action, so this one also has the same filter and untrigger-filter properties, and they filter on the inner scope

example:

<actions>
  <action id="do-stuff" untrigger-filter="always" scope="player">
    <message text="Giving speed!"/>
    <kit>
      <walk-speed>1.5</walk-speed>
    </kit>
  </action>
  <trigger filter="region" action="do-stuff" scope="player"/>
</actions>

When a player enters region they're sent the text and given the kit, when leaving the region the kit is removed. If untrigger-filter isn't defined, it defaults to never, and the player would keep the kit even after leaving

TheRealPear added a commit to TheRealPear/PGM-Docs that referenced this issue Aug 17, 2024
Resolves PGMDev#135

Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
@TheRealPear TheRealPear linked a pull request Aug 17, 2024 that will close this issue
TheRealPear added a commit to TheRealPear/PGM-Docs that referenced this issue Aug 27, 2024
Resolves PGMDev#135

Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
TheRealPear added a commit to TheRealPear/PGM-Docs that referenced this issue Oct 15, 2024
Resolves PGMDev#135

Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
TheRealPear added a commit to TheRealPear/PGM-Docs that referenced this issue Nov 14, 2024
Resolves PGMDev#135

Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant