Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scoreboard-filter to Blitz and Scoring page #137

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add scoreboard-filter to Blitz and Scoring page #137

merged 1 commit into from
Aug 27, 2024

Conversation

TheRealPear
Copy link
Contributor

Resolves #131, building on top of 600db7d

Pablete1234
Pablete1234 reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should note that for both blitz & score, this is a team-scoped dynamic filter, that can filter whether each team should show or not independently

@TheRealPear TheRealPear force-pushed the objective-filter-20240815 branch from 1fdc81f to 1176c43 Compare August 17, 2024 03:30
@TheRealPear TheRealPear force-pushed the objective-filter-20240815 branch from 1176c43 to 85f77e7 Compare August 18, 2024 14:58
CoWinkKeyDinkInc
CoWinkKeyDinkInc requested changes Aug 27, 2024
View reviewed changes
docs/modules/objectives/blitz.mdx Outdated Show resolved Hide resolved
docs/modules/objectives/scoring.mdx Outdated Show resolved Hide resolved
@TheRealPear
Add scoreboard-filter to Blitz and Scoring page
ba5a53e 
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
@TheRealPear TheRealPear force-pushed the objective-filter-20240815 branch from 85f77e7 to ba5a53e Compare August 27, 2024 17:00
@CoWinkKeyDinkInc CoWinkKeyDinkInc merged commit 721bc6b into PGMDev:master Aug 27, 2024
3 checks passed
@TheRealPear TheRealPear deleted the objective-filter-20240815 branch August 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pablete1234 Pablete1234 Pablete1234 approved these changes

@CoWinkKeyDinkInc CoWinkKeyDinkInc CoWinkKeyDinkInc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing objective filters
3 participants
@TheRealPear @CoWinkKeyDinkInc @Pablete1234