Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document proto 1.5.0 #151

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Document proto 1.5.0 #151

merged 7 commits into from
Oct 15, 2024

Conversation

TheRealPear
Copy link
Contributor

  • Changed recommended proto to 1.5.0
  • Added a section in proto page covering filter & variables IDs, non-match scoped triggers excluding observers, and action untrigger.
  • Replaced all mentions of 1.4.2 with 1.5.0 in examples where it was relevant.

Let me know if I've missed anything or should clarify more on something 👍

@TheRealPear
Document proto 1.5.0
8b290e6 
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
CoWinkKeyDinkInc
CoWinkKeyDinkInc reviewed Oct 7, 2024
View reviewed changes
docs/modules/general/proto.mdx Outdated Show resolved Hide resolved
docs/modules/general/proto.mdx Show resolved Hide resolved
TheRealPear and others added 2 commits October 7, 2024 10:16
@TheRealPear @CoWinkKeyDinkInc
Implement CoWink's suggested change
4aaff97 
Co-authored-by: Patrick <CoWinkKeyDinkInc@users.noreply.github.com>
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
@TheRealPear
Delete extra word
75d4ce3 
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
Pablete1234
Pablete1234 reviewed Oct 7, 2024
View reviewed changes
docs/modules/general/proto.mdx Outdated Show resolved Hide resolved
docs/modules/general/proto.mdx Outdated Show resolved Hide resolved
TheRealPear and others added 2 commits October 9, 2024 22:47
@TheRealPear @Pablete1234
Implement Pablo's suggested change (part 1)
0697f65 
Co-authored-by: Pablo Herrera <pabloherrerapalacio@gmail.com>
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
@TheRealPear
Implement Pablo's suggested change (part 2)
0b3d6e3 
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
@TheRealPear
Adjust untrigger notes
36745f0 
Based on updates in PGMDev/PGM#1411

Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
@TheRealPear
Fix XML issue in Race for Victory example
f1cadbc 
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
@CoWinkKeyDinkInc CoWinkKeyDinkInc merged commit a168281 into PGMDev:master Oct 15, 2024
1 check passed
@TheRealPear TheRealPear deleted the proto150 branch October 15, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pablete1234 Pablete1234 Pablete1234 left review comments

@CoWinkKeyDinkInc CoWinkKeyDinkInc CoWinkKeyDinkInc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealPear @CoWinkKeyDinkInc @Pablete1234