Check sampleset ID doesn't include and underscore (_)

[smlmbrt]

pgsc_calc/lib/SamplesheetParser.groovy

Lines 175 to 182 in 8bdf287

	private def checkReservedName(samplesheet) {
	def samplesets = samplesheet.collect { row -> row.sampleset }
	def n_bad_name = samplesets.count { it == "reference" }
	if (n_bad_name != 0) {
	Nextflow.error("Reserved sampleset name detected. Please don't call your sampleset 'reference'")
	}
	}

This module needs to check for reserved names as was done in the old sample sheet checking (no 'reference' or '_'): https://github.com/PGScatalog/pgscatalog_utils/blob/6da7eb0e157ba4e73f941233ee8d8ae4fb5e3926/pgscatalog_utils/samplesheet/check.py#L306-L322

[smlmbrt]

Fixed in 954330a

[Carldeboer]

I just encountered this bug and it is super confusing to have an error message "Reserved sampleset name detected. Please don't call your sampleset 'reference'" when the issue is actually that the sampleset name contains an underscore character. Took me hours of trial and error to determine that this was the cause. @nebfield

[smlmbrt]

@Carldeboer, we'll fix it to make it more specific. That's an omission on our part.

[Carldeboer]

thanks!