Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storeDir semantic structure #256

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Feb 28, 2024

Although we were only using stored files as a permanent cache and not publishing them, we were organising outputs into a semantic structure, e.g.:

storeDir $workDir/${meta.id}/${meta.chrom}

From nextflow docs:

The storeDir directive is meant for long-term process caching and should not be used to publish output files or organize outputs into a semantic directory structure. In those cases, use the publishDir directive instead.

As a side effect this also broke cloud executors in subtle ways.

Now flat directories are used and processes have been updated to correctly capture output file names, instead of using wildcards.

@nebfield nebfield marked this pull request as ready for review February 28, 2024 11:23
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@nebfield nebfield merged commit 8628fa8 into drop-report-aggregation Feb 28, 2024
@nebfield nebfield deleted the fix-cloud branch February 28, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants