Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0-beta.2 #341

Merged
merged 37 commits into from
Jul 31, 2024
Merged

v2.0.0-beta.2 #341

merged 37 commits into from
Jul 31, 2024

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Jul 19, 2024

Closes #325 #343 #333 #238

See #234


Changelog

Features

  • Add FID support internally (FID + IID must be unique for all samples)
  • Add parameters to tune target variant missingness (--pca_geno_miss_target, default maximum 10%) and/or MAF (--pca_maf_target, default no filtering) during intersection with the reference panel.
    • The new defaults will help help incorrect ancestry assignments when running the calculator on low sample sizes (revert to pre-beta version behaviour), as this behaviour was caused by the MAF filter before.
  • Add --efo_id parameter, deprecating --trait_efo which will be removed in a future release

Misc

@nebfield nebfield marked this pull request as ready for review July 29, 2024 15:29
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume we'll wait to merge until we finish the other PRs?

@nebfield nebfield changed the title Fix FID support v2.0.0-beta.2 Jul 30, 2024
@nebfield nebfield added this to the v2.0.0-beta.2 milestone Jul 30, 2024
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're finished with this release now.

@smlmbrt smlmbrt merged commit 69c467e into main Jul 31, 2024
234 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: could not broadcast input array from shape (3065,) into shape (2777,)
2 participants