Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.5.2 #81

Merged
merged 5 commits into from
Mar 7, 2024
Merged

v0.5.2 #81

merged 5 commits into from
Mar 7, 2024

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Feb 22, 2024 •
edited
Loading

Changelog

Bug fixes

  • Fix parsing optional is_dominant and is_recessive fields in some PGS Catalog scoring files (e.g. PGS000802)
  • Optimize speed and reliability of ancestry_analysis
  • Fix handling rare cases where PGS has 0 variance (skip)

nebfield and others added 5 commits February 22, 2024 10:21
@nebfield
fix handling of dominant / recessive
a607213
@nebfield
bump version
5901b8e
@nebfield
bump version
b1760da
@smlmbrt
Replace very slow merges with concatenations (of df subsets), and VER…
a713443 
…Y SLOW list comparisons with set overlaps.

Signed-off-by: smlmbrt <sam.a.lambert@gmail.com>
@smlmbrt
Handle [rare] case where PGS has 0 variance by abstaining from PGS ad…
4b61fa8 
…justment (outputting NAs and adding a WARNING to log).

Signed-off-by: smlmbrt <sam.a.lambert@gmail.com>
@nebfield nebfield marked this pull request as ready for review March 7, 2024 13:53
@nebfield nebfield requested a review from smlmbrt March 7, 2024 13:53
@nebfield nebfield merged commit bc8d87f into main Mar 7, 2024
3 checks passed
@nebfield nebfield deleted the dev branch March 7, 2024 13:55
smlmbrt
smlmbrt reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlmbrt smlmbrt smlmbrt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebfield @smlmbrt