Filter generic base types when seaching for the resource proxy type #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to properly include the projects in different solutions, e.g. to test changes in an application, we need to have the FileVersion set for the projects.
seveneleven
previously approved these changes
Dec 11, 2024
src/Tests/Moryx.Resources.Management.Tests/Mocks/ResourceWithGenericMethod.cs
Outdated
Show resolved
Hide resolved
1nf0rmagician
force-pushed
the
fix/resource-endpoint
branch
from
e2cf101 to
0e00a08
Compare
When inheriting from a generic base type without adding additional interfaces, a resource can still have a generated proxy. However, in that case the proxy builder would assume the generic base type to be the best possible fit, which cannot be proxified.
1nf0rmagician
force-pushed
the
fix/resource-endpoint
branch
from
0e00a08 to
026c569
Compare
seveneleven
approved these changes
Dec 12, 2024
Toxantron
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inheriting from a generic base type without adding additional interfaces, a resource can still have a generated proxy. However, in that case the proxy builder would assume the generic base type to be the best possible fit, which cannot be proxified.
Also, adds pre-set package file versions from major version.
Note: As described in #343 we currently don't plan to support generic resource proxies, this only prevents falsely assumed generic types