Vendor fprettify autoformater and add to CI #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately,
fprettify
autoformatter is not maintained much, and we need some fixes for it to work for ABIN. So we simply copy the source code with the fixes in the repo to make our lives simpler. The code can now be autoformatted simply by running(assuming the
configargparse
Python module is installed.)The formatter source code is vendored in
fprettify/
(no need to review those files).We now check the formatting in Github Actions, I've modified
CONTRIBUTING.md
accordingly.