-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schwenke numerical #174
Schwenke numerical #174
Conversation
… further calculations corrections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick review. It seems there are some indexing errors for the PIMD implementation of forces.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 92.77% 92.84% +0.06%
==========================================
Files 46 46
Lines 6700 6720 +20
Branches 754 754
==========================================
+ Hits 6216 6239 +23
+ Misses 472 469 -3
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@mbarnfield63 could you please push to GitHub the code that you're actually using to run the production MD? |
Implemented numerical_forces subroutine using forward differences for numerical force calculation.