Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schwenke numerical #174

Merged
merged 22 commits into from
Mar 11, 2024
Merged

Conversation

mbarnfield63
Copy link
Collaborator

Implemented numerical_forces subroutine using forward differences for numerical force calculation.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review. It seems there are some indexing errors for the PIMD implementation of forces.

.gitignore Outdated Show resolved Hide resolved
sample_inputs/input.in.cmd Outdated Show resolved Hide resolved
src/cvrqd_scan Outdated Show resolved Hide resolved
src/force_h2o.F90 Outdated Show resolved Hide resolved
src/force_h2o.F90 Outdated Show resolved Hide resolved
src/force_h2o.F90 Outdated Show resolved Hide resolved
src/force_h2o.F90 Outdated Show resolved Hide resolved
src/force_h2o.F90 Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (2b6a0b3) to head (431080d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   92.77%   92.84%   +0.06%     
==========================================
  Files          46       46              
  Lines        6700     6720      +20     
  Branches      754      754              
==========================================
+ Hits         6216     6239      +23     
+ Misses        472      469       -3     
  Partials       12       12              
Flag Coverage Δ
unittests 22.09% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/force_h2o.F90 92.75% <100.00%> (+9.08%) ⬆️

src/force_h2o.F90 Outdated Show resolved Hide resolved
@danielhollas
Copy link
Contributor

@mbarnfield63 could you please push to GitHub the code that you're actually using to run the production MD?

@danielhollas danielhollas merged commit b5383db into PHOTOX:master Mar 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants