Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting NaI conversion units for NAC #194

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Correcting NaI conversion units for NAC #194

merged 1 commit into from
Nov 30, 2024

Conversation

JanosJiri
Copy link
Contributor

Fixing #193 where the problem is detailed. Benchmarked to quantum dynamics but this time with correct decoh_alpha=1.0.

@JanosJiri JanosJiri linked an issue Nov 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (5e79a24) to head (a7ca3d2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   92.76%   92.76%   -0.01%     
==========================================
  Files          47       47              
  Lines        6693     6692       -1     
  Branches      757      757              
==========================================
- Hits         6209     6208       -1     
  Misses        472      472              
  Partials       12       12              
Flag Coverage Δ
unittests 20.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/potentials_sh.F90 91.93% <ø> (-0.13%) ⬇️

@JanosJiri
Copy link
Contributor Author

@danielhollas I created a separate PR for fixing the NaI unit conversion as we discussed in #186 . It's literally deleting one line of the code and then updating the test. If you approve, we can then proceed with merging #186.

@danielhollas
Copy link
Contributor

Perfect, thanks so much for extracting this and creating an issue with details. Feel free to merge this.

@JanosJiri JanosJiri marked this pull request as ready for review November 30, 2024 16:50
@JanosJiri JanosJiri merged commit 510a8b0 into master Nov 30, 2024
19 checks passed
@JanosJiri JanosJiri deleted the nai_conversion branch November 30, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion units in NaI potential
2 participants